-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
Fix ProUI LCD off freezing #27832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ProUI LCD off freezing #27832
Conversation
The first click when the display is asleep should probably be ignored. If it is not, that adjustment should be made. |
very nice, was this tested? i can do that right now |
oh. also this PR might fix #27722 I believe that was the issue, but no response from OP confirming. |
@thinkyhead there is a slight issue. so the LCD should come back to full functionality whether the knob is turned or pressed in. currently, this gives partially full functionality. so when the screen is off, turning the knob or pressing the button does bring the screen back on, and you can navigate freely (like normal) however, you have to press the knob in (again) in order to work like it did when the screen was on. |
should I make a seperate PR?, I fixed this by reverting void MarlinUI::_set_brightness() {
- if (!backlight) wait_for_user = true;
- dwinLCDBrightness(backlight ? brightness : 0);
}
void MarlinUI::_set_brightness() {
+ if (backlight) {
+ dwinLCDBrightness(brightness);
+ wait_for_user = false;
+ }
+ else {
+ dwinLCDBrightness(0);
+ wait_for_user = true;
+ }
} |
Yes. The PR you’re commenting in has already been merged and closed. |
Description
When using ProUI, and the LCD turns off, turning the knob may bring the LCD screen back on, however it stays frozen. The only way to bring this back is to press in the knob.
This PR makes it so pressing in the knob or turning it not only returns the screen back on, but functionality.
Requirements
Benefits
No more frustration when turning the knob and finding a frozen screen.
Configurations
Related Issues