GD32: Fast GPIO optimization #27845
Merged
GD32: Fast GPIO optimization #27845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding FORCE_INLINE to the fast GPIO functions gives us a couple benefits. First, code folding will reducing these functions to their direct register accesses - which is ideal. Second, it allows us to optimize away the pin-port map - reducing code size (~250 bytes or so) as well as eliminating all overhead. This has been verified via decompilation. The only down side is that the EEPROM (software IIC) seems to rely on this overhead to meet timing requirements, and since we now have zero overhead, writing to the EEPROM is broken. I'll submit another PR with that fix.
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding FORCE_INLINE to the fast GPIO functions gives us a couple benefits.
First, code folding will reduce these functions to their direct register accesses - which is ideal.
Second, it allows us to optimize away the pin-port map - reducing code size (~250 bytes or so) as well as eliminating all overhead.
This has been verified via decompilation.
The only down side is that the EEPROM (software IIC) seems to rely on this overhead to meet timing requirements, and since we now have zero overhead, writing to the EEPROM is broken.
I'll submit another PR with that fix.
Requirements
GD32 Board
Benefits
Zero overhead for IO and smaller code size.
Configurations
N/A
Related Issues
N/A