Small fixes - proper return in void, omit unused

[classicrocker883]

Description

More to come

Change to Linear Advance in ProUI dwin.cpp does not work:

• Partially revert 12fdde2 "⚡️ Optimize Smooth Linear Advance (via fixed-point) Fixed point smooth linear advance (makes it available to all 32 bit boards) #27818"
• • Adjust applying Linear Advanced with correct POW() / use editable_decimal_k as to "future proof"

Omit:

• Omit unused in planner.h + Conditionals-2-LCD.h

Fixes for additional Check All errors/warnings:

• See Related Issues

Use proper return in void functions:

• Move if (blah blah) return [code] down for void functions
• • example: if (blah blah) { [code]; return; }

• Adjust some spacing

Requirements

Benefits

Configurations

Related Issues

To see what errors/warnings show, do the following:
PlatformIO > Default (or another env) > Advanced > Check All

• [high:error] failed to expand 'DO', Wrong number of parameters for macro '_DO_2'. [preprocessorErrorDirective]

• • #define _DO_N

• [medium:warning] Comparison of a boolean expression with an integer.

• • #define _ABS

• [low:performance] Function parameter 'pxy' should be passed by const reference. [passedByValue]

• • FI void set(const XYval<T> pxy, const T pz, const T pe) { set(pxy, pz); e = pe; }

[classicrocker883]

something wrong with Linear Advance, it will take a value, like 0.01, then turn to 0.10, then 1000.0, after every time you click on it or switch menu.

I believe it has to use an intermediate variable, such as like used for JyersUI, that might be the issue.

has the value changed for K? should it also be / MINUNITMULT for getting/reading the value? seems so

update: so it should be POW(10, 3)

[thinkyhead]

Fixed to bypass "ok" but still do SERIAL_IMPL.msgDone().