-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
[SMOOTH_LINEAR_ADVANCE] Fix underflow on disabled shaping AND e-synch when only one axis is shaped #27862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SMOOTH_LINEAR_ADVANCE] Fix underflow on disabled shaping AND e-synch when only one axis is shaped #27862
Conversation
This PR did fix my issue of M593 causing a printer lockup when setting values below that in the config (with MIN_FREQ not set). However, it also causes some ugly stepper noises when using M593 below what's set in the config - I'll have to test to see if setting MIN_FREQ prevents that. |
Confirmed that setting a SHAPING_MIN_FREQ to a lower value than will be used by M593 does stop the clunky extruder noises. Anything else you want me to test? |
Oh yes going below SHAPING_MIN_FREQ will make e-synch read from out of the buffer. I.e it will be quasi random |
Thanks for the testing btw :) |
So, once one is done with tuning input shaping, is there any issue with
leaving a lower MIN_FREQ value enabled? Or should that be turned on for
tuning, and off once values are finalized? Since it seems to have an impact
on buffer calculations, it seems it would be ideal to have that off when
not needing to change the values.
…On Sat, May 17, 2025 at 12:06 PM David Buezas ***@***.***> wrote:
*dbuezas* left a comment (MarlinFirmware/Marlin#27862)
<#27862 (comment)>
Thanks for the testing btw :)
—
Reply to this email directly, view it on GitHub
<#27862 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6SRTTTO5APPTMKMQJNC3HT266CC5AVCNFSM6AAAAAB5KTLTSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBYGU2DCNRRGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
No, it will just use a bit more ram if you set it lower than needed. On a side note: have you already tried higher acceleration printing? Have you otherwise noted quality improvements? And what is your k value? |
I’m using a fairly bare bones Ender-3 Pro with the SKR Mini E3 V1.2 and the
stock Bowden tube. My K value is 0.4, currently I’m using acceleration of
3000. I’m working on getting the IS really dialed in so I can try
increasing the acceleration more - above 3000 it still prints fine but I
start getting ringing, and I’d like to keep that to a minimum.
Interestingly, I printed a calibration cube with K0.1 to K0.5 and could not
detect any noticeable difference.
…On Sat, May 17, 2025 at 12:28 PM David Buezas ***@***.***> wrote:
*dbuezas* left a comment (MarlinFirmware/Marlin#27862)
<#27862 (comment)>
any issue with
leaving a lower MIN_FREQ value enabled
No, it will just use a bit more ram if you set it lower than needed. On a
side note: have you already tried higher acceleration printing? Have you
otherwise noted quality improvements? And what is your k value?
—
Reply to this email directly, view it on GitHub
<#27862 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6SRTTQKN22N322CTIO3H6L266EVDAVCNFSM6AAAAAB5KTLTSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBYGU2DSNBTGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Oh bowden, I'm very curious how it works on bowden. Did you print the cube also without smooth LA? Does your extruder make noises? If it does increase tau. |
I haven’t had any noises with the default .02 tau, haven’t tried tweaking
it yet either.
Smooth Lin advance seems to improve quality with the Bowden quite nicely -
with the Marlin test g-code for Lin advance, the lines are coming out near
perfectly. Previously I had to choose between the acceleration end or the
deceleration end looking right, now both are consistent.
Is there any kind of recommended range to try when adjusting tau? I see
you’ve said it could be as low as .0075, but I’m not sure what a reasonable
upper end would be (or I guess there’s no real reason to go above .02?)
…On Sat, May 17, 2025 at 12:45 PM David Buezas ***@***.***> wrote:
*dbuezas* left a comment (MarlinFirmware/Marlin#27862)
<#27862 (comment)>
Oh bowden, I'm very curious how it works on bowden. Did you print the cube
also without smooth LA? Does your extruder make noises? If it does increase
tau.
—
Reply to this email directly, view it on GitHub
<#27862 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6SRTTTOEL4L7ALFTCBCW5L266GXDAVCNFSM6AAAAAB5KTLTSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBYGU2TMMRUGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Also, what is there to be gained by adjusting Tau? Will it increase speed
or quality as its decreased, or just affect the load on the processor?
On Sat, May 17, 2025 at 12:51 PM Chris White ***@***.***>
wrote:
… I haven’t had any noises with the default .02 tau, haven’t tried tweaking
it yet either.
Smooth Lin advance seems to improve quality with the Bowden quite nicely -
with the Marlin test g-code for Lin advance, the lines are coming out near
perfectly. Previously I had to choose between the acceleration end or the
deceleration end looking right, now both are consistent.
Is there any kind of recommended range to try when adjusting tau? I see
you’ve said it could be as low as .0075, but I’m not sure what a reasonable
upper end would be (or I guess there’s no real reason to go above .02?)
On Sat, May 17, 2025 at 12:45 PM David Buezas ***@***.***>
wrote:
> *dbuezas* left a comment (MarlinFirmware/Marlin#27862)
> <#27862 (comment)>
>
> Oh bowden, I'm very curious how it works on bowden. Did you print the
> cube also without smooth LA? Does your extruder make noises? If it does
> increase tau.
>
> —
> Reply to this email directly, view it on GitHub
> <#27862 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A6SRTTTOEL4L7ALFTCBCW5L266GXDAVCNFSM6AAAAAB5KTLTSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBYGU2TMMRUGA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
Oh sounds good. If you could at some point make some before/after pics of that I'd really appreciate it, I plan to make a page in Marlin's help and I only have my own machine which has very low k. Increasing tau would smooth extrusion even more, it's only worth it if the extruder starts skipping. Otherwise keep it low for highest accuracy |
…haped (cherry picked from commit f69b336)
fd3dba1
to
c496ed2
Compare
Description
There are three bugs in the current implementation:
misbehavedegrade, and also happens to make e-synch crash marlin. I left a mitigation commented out, and it shouldn't be used since it will result in extrusion issues, and uncommenting it would just hide them.Regarding the lower frequency limit issue, I see multiple options:
Maybe it would be best to combine them all?
Requirements
Benefits
Configurations
Related Issues