Skip to content

Italian translation typo fix #27890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GMagician
Copy link
Contributor

No description provided.

@GMagician
Copy link
Contributor Author

'LanguageWide_it' is used on lcd with 20 or more chars. I noticed that some messages are too long for a simple reprap discount.
I wrongly supposed that 'LanguageNarrow_it' should be used for such display. Are there some LCD narrow than reprap?
If so I suspect I have to revisit all messages in both namespaces....

@thinkyhead
Copy link
Member

I made the "LanguageWide" namespaces apply to a LCD_WIDTH >= 20 to maintain the status quo in #25889. The "LanguageNarrow" namespaces can be considered to apply to character displays and archaic 16-character-wide displays, but we never took the time to come up with hundreds of "very short" menu titles because it's a tedious process. So those with 16-character-wide displays just have to suffer with cut-off menu titles, but we could help them out by making ordinary menu titles scroll on very narrow displays. It might be more logical at this time to make the LanguageWide namespaces use "LCD_WIDTH >= 21" instead so they would apply to graphical display but not to 20-character wide displays.

At some point we'll do a more radical re-organization and refactor of translated / LCD messages. Some messages are screen titles or static items that can use the full display width, others are sub-menu items that need space to display an arrow, and some others are edit items that need to leave space for a colon and a value. We want to keep related items together, but we also need some convention to distinguish a "MeSsaGe" from a "TiTLe" or a SUBmenu… so there's a little more clarity about length restrictions.

@thinkyhead thinkyhead merged commit 5b59424 into MarlinFirmware:bugfix-2.1.x May 27, 2025
66 checks passed
@GMagician
Copy link
Contributor Author

Thanks for clarification. Once re-organization will occur I'll take care of adjust messages lenghts.
All the messages I can see in my standard use are correct in length but others I can't be so sure.

@GMagician GMagician deleted the Italian-translation-typo-fix branch May 27, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants