Use 0x70 bitmask for TargetID #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right, they (0x20, 0x30 and 0x40) should have 0x70 bitmask applied before matching. Thanks for the fix and for pointing me to the explanation 👍 . Luckily, one of the test samples benefits from this fix and can prove it (the failing one). I will merge this PR and fix this test afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not thoroughly tested this, but this change should at least work for a file with an
item_typeof 195 (0xC3). The current logic doesn't work since 0xC3 is larger than 0x4F.Closes #37