Skip to content

Update update_license_headers.py#164

Closed
TheSecondAmigo wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
TheSecondAmigo:patch-1
Closed

Update update_license_headers.py#164
TheSecondAmigo wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
TheSecondAmigo:patch-1

Conversation

@TheSecondAmigo

Copy link
Copy Markdown

If we change skip_patterns to a tuple instead of a list, we can just use the str.endswith() function to checking for matches instead of iterating over a list.

If we change skip_patterns to a tuple instead of a list, we can just use the str.endswith() function to checking for matches instead of iterating over a list.
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

@TheSecondAmigo

Copy link
Copy Markdown
Author

recheck

@johnnygreco

Copy link
Copy Markdown
Contributor

Hey @TheSecondAmigo – thank you for this contribution. We had some refactoring in flight related to this script. I think it makes sense to go ahead and close this PR for now. If you are interested in contributing, that is awesome! Please be on the lookout for "good first issue" Issues, which we plan to add as we ramp up this newly open-source project.

Thanks again for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants