Update update_license_headers.py#164
Closed
TheSecondAmigo wants to merge 1 commit into
Closed
Conversation
If we change skip_patterns to a tuple instead of a list, we can just use the str.endswith() function to checking for matches instead of iterating over a list.
Contributor
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Author
|
recheck |
Contributor
|
Hey @TheSecondAmigo – thank you for this contribution. We had some refactoring in flight related to this script. I think it makes sense to go ahead and close this PR for now. If you are interested in contributing, that is awesome! Please be on the lookout for "good first issue" Issues, which we plan to add as we ramp up this newly open-source project. Thanks again for your interest! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we change skip_patterns to a tuple instead of a list, we can just use the str.endswith() function to checking for matches instead of iterating over a list.