Align aggregate metrics with persisted rollouts#1799
Merged
marta-sd merged 2 commits intoJul 24, 2026
Merged
Conversation
marta-sd
self-requested a review
July 16, 2026 07:19
marta-sd
reviewed
Jul 16, 2026
marta-sd
left a comment
Contributor
There was a problem hiding this comment.
Thanks you for your contribution @fallintoplace !
I added one small comment. Also please sign your commits as described in contributing guideliness so we can accept your PR :)
Contributor
|
/ok to test f55751e |
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
fix/aggregate-only-persisted-rollouts
branch
from
July 16, 2026 12:00
f55751e to
22ea6ac
Compare
marta-sd
approved these changes
Jul 24, 2026
Contributor
Author
|
Somehow the CI fails. I can have a look later today. |
5 tasks
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ng_no_persistattempts out of runtime/aggregate_metricsRoot cause
run_from_config()appended every result to the in-memoryresultslist before the persistence gate, then passed that full list into_call_aggregate_metrics(). That let runtime aggregation include rows that never landed inoutput.jsonl, sogym eval runcould disagree withgym eval aggregate.Validation
uv run --extra dev python -m pytest tests/unit_tests/test_rollout_collection.py