Nina xu/pii repl v3 alt config#672
Draft
nina-xu wants to merge 3 commits into
Draft
Conversation
…uctured columns. Write auto-discovered plans to pii_replacement_plan.yaml and omit null fields. In MVP mode, skip free-text column scanning when no replaceable structured PII is detected because there is nothing to propagate.
…persona only condition persona-sourced fields Signed-off-by: nina-xu <19981858+nina-xu@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| try: | ||
| foreach_itr = json.loads(foreach_str) | ||
| except (json.JSONDecodeError, TypeError): |
Comment on lines
+57
to
+61
| from data_designer.config.utils.constants import ( | ||
| DEFAULT_AGE_RANGE, | ||
| MAX_AGE, | ||
| MIN_AGE, | ||
| ) |
| "micronesian": ["micronesian", "marshallese", "palauan"], | ||
| } | ||
| # Closed vocabulary used by the PGM persona sampler. | ||
| PGM_ETHNIC_CATEGORIES: tuple[str, ...] = tuple(_PGM_ETHNIC_ALIASES) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-Review Checklist
Ensure that the following pass:
mise run format && mise run checkor via prek validation.mise run testpasses locallymise run test:e2epasses locallymise run test:ci-containerpasses locally (recommended)/syncon this PR to trigger a run (auto-triggers on ready-for-review)Pre-Merge Checklist
Other Notes