Previously CUDA_ENFORCE_LOWER was used with CUDA_VER_10_1_UP, which ensured the CUDA version was at least 10.1. Here was the explanation on how to use CUDA_ENFORCE_LOWER:
https://github.com/rapidsai/raft/blob/e74a6884072ca75a5cb662bcb154959a66d27372/cpp/include/raft/core/cusparse_macros.hpp#L15-L25
Also here was a usage example:
https://github.com/rapidsai/raft/blob/e74a6884072ca75a5cb662bcb154959a66d27372/cpp/include/raft/spectral/detail/matrix_wrappers.hpp#L216-L218
However support for CUDA 9, 10 (and even CUDA 11) have been dropped. Meaning CUDA_VER_10_1_UP is always true and thus is no longer used. As a result, recent code looks like this:
https://github.com/rapidsai/raft/blob/6725e0f54446a4cac83b1f13d2664b42ca05483b/cpp/include/raft/spectral/detail/matrix_wrappers.hpp#L217-L219
Given this, is CUDA_ENFORCE_LOWER still needed?
- If so, what does it mean for CUDA 12+ code?
- If not, what should happen to the code it guards?
Previously
CUDA_ENFORCE_LOWERwas used withCUDA_VER_10_1_UP, which ensured the CUDA version was at least 10.1. Here was the explanation on how to useCUDA_ENFORCE_LOWER:https://github.com/rapidsai/raft/blob/e74a6884072ca75a5cb662bcb154959a66d27372/cpp/include/raft/core/cusparse_macros.hpp#L15-L25
Also here was a usage example:
https://github.com/rapidsai/raft/blob/e74a6884072ca75a5cb662bcb154959a66d27372/cpp/include/raft/spectral/detail/matrix_wrappers.hpp#L216-L218
However support for CUDA 9, 10 (and even CUDA 11) have been dropped. Meaning
CUDA_VER_10_1_UPis always true and thus is no longer used. As a result, recent code looks like this:https://github.com/rapidsai/raft/blob/6725e0f54446a4cac83b1f13d2664b42ca05483b/cpp/include/raft/spectral/detail/matrix_wrappers.hpp#L217-L219
Given this, is
CUDA_ENFORCE_LOWERstill needed?