Skip to content

Is CUDA_ENFORCE_LOWER still needed? #2856

Description

@jakirkham

Previously CUDA_ENFORCE_LOWER was used with CUDA_VER_10_1_UP, which ensured the CUDA version was at least 10.1. Here was the explanation on how to use CUDA_ENFORCE_LOWER:

https://github.com/rapidsai/raft/blob/e74a6884072ca75a5cb662bcb154959a66d27372/cpp/include/raft/core/cusparse_macros.hpp#L15-L25

Also here was a usage example:

https://github.com/rapidsai/raft/blob/e74a6884072ca75a5cb662bcb154959a66d27372/cpp/include/raft/spectral/detail/matrix_wrappers.hpp#L216-L218

However support for CUDA 9, 10 (and even CUDA 11) have been dropped. Meaning CUDA_VER_10_1_UP is always true and thus is no longer used. As a result, recent code looks like this:

https://github.com/rapidsai/raft/blob/6725e0f54446a4cac83b1f13d2664b42ca05483b/cpp/include/raft/spectral/detail/matrix_wrappers.hpp#L217-L219


Given this, is CUDA_ENFORCE_LOWER still needed?

  • If so, what does it mean for CUDA 12+ code?
  • If not, what should happen to the code it guards?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    Todo
    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions