Returned detailed message when query validation rules not configured #3041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when query validation rules are not configured for a ShardQueryLogic bean, the resulting exception and message is identical to the default UnsupportedOperationException thrown by the QueryLogic interface. This is misleading, since the operation is supported, but additional configuration is required. Update the ShardQueryLogic to instead throw a BadRequestQueryException with the error code 412-19 and a message indicating that query validation rules need to be configured for the underlying logic before validation can proceed. Additionally, add the option -VQ | --validateQuery to the quickstart datawaveQuery function to make the command post a query to the validate endpoint.
foster33
previously approved these changes
Aug 1, 2025
avgAGB
reviewed
Aug 11, 2025
...base-rest-responses/src/main/java/datawave/webservice/query/exception/DatawaveErrorCode.java
Outdated
Show resolved
Hide resolved
…ry/exception/DatawaveErrorCode.java Co-authored-by: Mr. Patrickus Agbius <[email protected]>
foster33
approved these changes
Aug 11, 2025
avgAGB
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when query validation rules are not configured for a ShardQueryLogic bean, the resulting exception and message is identical to the default UnsupportedOperationException thrown by the QueryLogic interface. This is misleading, since the operation is supported, but additional configuration is required.
Update the ShardQueryLogic to instead throw a BadRequestQueryException with the error code 412-19 and a message indicating that query validation rules need to be configured for the underlying logic before validation can proceed.
Additionally, add the option
-VQ | --validateQueryto the quickstart datawaveQuery function to make the command post a query to the validate endpoint.