Bottom Bar #364
Merged
Bottom Bar #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalva97
requested changes
May 6, 2023
testomania/src/main/kotlin/com/earth/testomania/ui/theme/Color.kt
Outdated
Show resolved
Hide resolved
| val DarkRed = Color(0xffba1a1a) | ||
| val BottomBarColorDark = Color(0xff262c39) | ||
| val BottomBarColorLight = Color(0xffededee) |
There was a problem hiding this comment.
btw, we should try to use colors only from Kiwi. this might have bad contrast on dark theme
There was a problem hiding this comment.
@shalva97
I checked in both scenarios, in dark and in light and it looks good, I do not think that kiwi has exact same colors and other colors do not look well
shalva97
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.