Skip to content

[16.0][FIX]hr_holidays_public: handle incompatibility with hr_work_entry_holidays by propagating the context upwards #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

PicchiSeba
Copy link

@PicchiSeba PicchiSeba commented Apr 7, 2025

The method _get_number_of_days introduced in hr_work_entry_holidays, is not being passed exclude_public_holidays in the context.
With this PR we propagate it in the calling methods too.

@PicchiSeba PicchiSeba force-pushed the 16.0-holidays-incorrect-time-off-amount branch 2 times, most recently from 9c8e728 to 47e74b7 Compare April 7, 2025 10:45
@PicchiSeba PicchiSeba marked this pull request as draft April 7, 2025 10:49
@PicchiSeba PicchiSeba force-pushed the 16.0-holidays-incorrect-time-off-amount branch from 47e74b7 to 69f24b2 Compare April 8, 2025 07:15
@PicchiSeba PicchiSeba marked this pull request as ready for review April 8, 2025 07:19
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 10, 2025
@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 10, 2025
@aleuffre
Copy link

Hello @OCA/human-resources-maintainers , admittedly this is something of a hack but we've been using it in production for a couple of months now, and it works. Could you take a look?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants