Skip to content

Issue 7705, 7704 - Percent Flow bug fix, Scrollbar fix #7709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

Conversation

nbintertech
Copy link
Collaborator

@nbintertech nbintertech requested a review from Copilot August 15, 2025 16:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses two issues: fixing a percent flow calculation bug and improving scrollbar functionality. The changes ensure proper handling of null/zero flow values in percentage calculations and restructure drawer/tab panel components to fix scrolling issues.

  • Fixes percent flow calculation to avoid processing null/zero values
  • Restructures tab panel and drawer components for better scrollbar behavior
  • Removes unused layout wrapper components and simplifies component structure

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SourceFlowForm.tsx Adds null check to prevent percent calculation on null flow values
DischargeFlowForm.tsx Adds null check to prevent percent calculation on null flow values
ComponentDataForm.tsx Removes unused import and simplifies component structure
TabPanel.tsx Restructures component to use CSS flexbox for proper scrolling
SharedDrawer.tsx Moves padding styles to drawer paper and removes inner box wrapper
MenuSidebar.tsx Removes dimension props and simplifies component structure
ManageEdge.tsx Removes TabPanelBox wrapper components
ManageComponent.tsx Simplifies component structure and removes unnecessary box wrappers
ComponentNameHeader.tsx Simplifies component structure by removing nested box elements
Diagram.tsx Removes dimension props from MenuSidebar component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nbintertech nbintertech merged commit e9486ae into develop Aug 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants