i.in.spotvgt: bug fixes

[jayneel-shah18]

This PR addresses the four issues in the i.in.spotvgt module that previously led to incorrect imports or completely null raster outputs as highlighted in #6175.

Summary of Changes:

• Line if f < 2: caused type error due to comparison of list directly, it has been correctly fixed as if len(f) < 2:
• Previously, qname = spotname.replace("NDV", "SM") resulted in missing file error due to missing extension. This has been fixed by changing it to qname = spotname.replace("NDV", "SM") + ".HDF"
• In the old version,

rules = [
    r + "\n"
    for r in [
        "8 50 50 50",
        ...
    ]
]
gs.write_command("r.colors", map=smfile, rules="-", stdin=rules)

raised TypeError as stdin can only accept string or bytes. This has been fixed by modifying it to:

rules = """8 50 50 50
11 70 70 70
...
252 green
"""

• Line gs.use_temp_region() caused the output map to be null, since the temporary region prevented g.rename and r.mapcalc results from being preserved in main mapset. This line has been commented out.

This PR closes #6175.

[echoix]

I have a question/suggestion for the rules block change, and I'm not sure of commenting out the temporary project and its effects. Please someone evaluate this.

[echoix]

Is it possible to verify that the string doesn't have leading whitespace?

If you start by changing to something like the "bad" of this rule: https://docs.astral.sh/ruff/rules/static-join-to-f-string/, so using str.join(), you should end up with ruff making a suggestion for the correct fix.

So, something like removing the list brackets:

Suggested change

	rules = """8 50 50 50
	11 70 70 70
	12 90 90 90
	60 grey
	155 blue
	232 violet
	235 red
	236 brown
	248 orange
	251 yellow
	252 green
	"""
	rules = "\n".join([
	"8 50 50 50",
	"11 70 70 70",
	"12 90 90 90",
	"60 grey",
	"155 blue",
	"232 violet",
	"235 red",
	"236 brown",
	"248 orange",
	"251 yellow",
	"252 green",
	]
	)

And then applying the fixes unblocked. Having this inside a list was probably preventing rules to apply at it wouldn't have meant the same.

[jayneel-shah18]

I initially tried using "\n".join([...]), but Ruff’s FLY002 check flagged it. To avoid leading whitespace issues and still satisfy Ruff, I will switch to the following:

rules = (
    "8 50 50 50\n"
    "11 70 70 70\n"
    "12 90 90 90\n"
    "60 grey\n"
    "155 blue\n"
    "232 violet\n"
    "235 red\n"
    "236 brown\n"
    "248 orange\n"
    "251 yellow\n"
    "252 green\n"
)