Skip to content

File return type fix #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2020
Merged

Conversation

minenok-tutu
Copy link
Contributor

@minenok-tutu minenok-tutu commented Mar 20, 2020

Fixed parsing for file return type in golang

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@minenok-tutu
Copy link
Contributor Author

@wing328 wing328 added this to the 4.3.1 milestone May 3, 2020
@wing328
Copy link
Member

wing328 commented May 3, 2020

@wing328 wing328 changed the title file return type fix File return type fix May 3, 2020
@wing328 wing328 merged commit cd88c06 into OpenAPITools:master May 3, 2020
@wing328
Copy link
Member

wing328 commented May 3, 2020

@minenok-tutu thanks for the PR, which has been merged into master.

When you've time, I wonder if you can make the same enhancement to the go-experimental client generator. Thank you.

@wing328
Copy link
Member

wing328 commented May 7, 2020

@minenok-tutu thanks for the PR, which has been included in the v4.3.1 release: https://twitter.com/oas_generator/status/1258057660974329861

michaelpro1 pushed a commit to michaelpro1/openapi-generator that referenced this pull request May 7, 2020
* file return type fix

* Update client.mustache
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request May 31, 2020
* file return type fix

* Update client.mustache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants