[scala][akka-http] fix non-default packages for api, model and invoker #6129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chameleon82
force-pushed
the
bug-scala-akka-main-package
branch
from
58cf744 to
c8ca921
Compare
|
@chameleon82 thanks for the PR, which has been included in the v4.3.1 release: https://twitter.com/oas_generator/status/1258057660974329861 |
michaelpro1
pushed a commit
to michaelpro1/openapi-generator
that referenced
this pull request
May 7, 2020
OpenAPITools#6129) * [scala][akka-http] fix non-default packages for api, model and invoker * remove default invoker additionalProperty * fix invoker package for scala-akka and sttp * fix invoker package and settings for scala-akka * fix tests compatible with windows paths * test output * test output * fix base output path for test * fix output path for test * fix sttp invoker package
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
May 31, 2020
OpenAPITools#6129) * [scala][akka-http] fix non-default packages for api, model and invoker * remove default invoker additionalProperty * fix invoker package for scala-akka and sttp * fix invoker package and settings for scala-akka * fix tests compatible with windows paths * test output * test output * fix base output path for test * fix output path for test * fix sttp invoker package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default setting for mainPackage is
org.openapitools.clientand it will be always next values for:api = mainPackage + .apiinvoker = mainPackage + .invokermodel = mainPackage + .modelThere is a cases when i want to define all of 3 properties explicitly ( sbt-plugin / gradle-plugin ) or to have custom values.
This fix allows to apply explicitly every property and combine with
mainPackagewhen applicable#6128
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)