Add a way to import character into a new loadout - #10061
Draft
xoxorwr wants to merge 2 commits into
Draft
Conversation
Contributor
|
What's the idea behind this? Wouldn't you normally import your build normally and then import the guide build as a comparison? I do welcome any import UI change attempts, though. It ended up feeling sort of duplicated imo. But it seems like the default is site import here? I don't think that's ideal since bandit choices are oauth-only. There are also some differences which could be useful in the future like items having mod ids and the AG items |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
This drastically simplify the process of importing/managing your actual character when following a build guide.
I also took the opportunity to refine the import UI.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
2026-07-29.17-26-03.mp4
I'm submitting this as a draft because I'm not happy with the code, the original code had bunch of duplicated widgets to handle both import modes, so I had to work with that in mind, I'm thinking of rewriting the whole module from scratch, but it's kind of a daunting task, I'll think about it more on a later date.