Skip to content

rm demonstrations folder #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Alan-eMartin
Copy link
Collaborator

@Alan-eMartin Alan-eMartin commented Aug 20, 2025

Summary

This PR removes all legacy v1 workflows and the demonstrations v1 directory containing all v1 demos.

Note:
I have not completely removed everything from our github dir as I am unsure if some of these files and directories are still relevant.

I am wondering if @rashidnhm could and @mudit2812 could verify some of these before deleting.

  • generate_diffs.py I believe this is the old, old version of diff checker?
  • html_parser.py Also part of legacy diff checker?
  • qml_pipeline_utils/ directory.
  • artifact.yml

Also — please let me know if I should restore anything, I did my best to investigate.

Copy link
Collaborator

@doctorperceptron doctorperceptron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

I believe there is a V2 workflow in the qml_pipeline_utils/ directory, but I think the rest of the files you suggested can be removed.

@mudit2812
Copy link
Contributor

mudit2812 commented Aug 20, 2025

generate_diffs.py I believe this is the old, old version of diff checker?
html_parser.py Also part of legacy diff checker?

Yes, and yes. Those should actually have been removed years ago 😅

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about qml_pipeline_utils or artifact.yml, but it should be safe to delete the other two files you asked about. Otherwise, the removals seem fine to me. Will approve once those are removed.

@mudit2812
Copy link
Contributor

Not sure if this is already on your radar, but the update-dev workflow should probably be triggered right away after this PR gets merged to also update dev.

@Alan-eMartin
Copy link
Collaborator Author

Not sure if this is already on your radar, but the update-dev workflow should probably be triggered right away after this PR gets merged to also update dev.

Yep, this has been updated already in a previous PR.

@Alan-eMartin Alan-eMartin requested a review from mudit2812 August 20, 2025 20:46
@Alan-eMartin
Copy link
Collaborator Author

Thanks @mudit2812 – I have gone ahead and removed those legacy scripts for the diff checker.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

Copy link
Collaborator

@ashishks0522 ashishks0522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️ ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants