openapi.yml API Error

[li-lance]

Steps to Reproduce:

The 'held_items' in the Pokemon details is incorrectly defined; it should be a array.

Below is the actual API call situation

[Naramsim]

@Indyandie i may have forgotten whether it was you implementing OpenApi

[Indyandie]

@Naramsim it was me. I can't look into this at the moment. I'll take a look when I have some free time.

However, the fix should be pretty straightforward if someone is familiar with the OpenAPI spec.

[PraaneshSelvaraj]

@Naramsim I am interested in this, Can I work on this?

[Naramsim]

Of course! Go ahead and then ask @Indyandie for a PR review

[PraaneshSelvaraj]

@Naramsim Sure I'll start working on it and will tag @Indyandie for a review once the PR is ready.

[Indyandie]

Thanks for helping out @PraaneshSelvaraj! 🙇

[PraaneshSelvaraj]

Hey @Indyandie! Just wondering - is the openapi.yml file here a static file that’s maintained manually, or is it generated automatically from the code using something like Django Spectacular?

[Indyandie]

The latter, here's the initial PR #1046

[PraaneshSelvaraj]

Hey @Indyandie, I think I’ve fixed the issue. Should I create a PR with just the updated serializer, or should I also include the newly generated openapi.yml file?

[Indyandie]

Create a PR with the changes you made and we can discuss the details there.

[PraaneshSelvaraj]

Hey @Indyandie, I have created a pull request with the fix: #1248. Please have a look when you get a chance.