Handle sensor_id via roslaunch arg/param and set_sensor_id service #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes for multiple radars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a patch to make the radar use a configurable sensor_id, which can be set via roslaunch arg.
This also makes it possible to use the radar without problems after calling the
set_sensor_idservice without restarting the node as it updates the current sensor id and starts looking for the correct message IDs after a change. After a restart of the node, the roslaunch arg/param has to be set to the new sensor_id, of course.Also included is a converter from object lists to ROS radardetection messages. Haven't yet added the function to convert from cluster lists but might do.