fix: strip ANSI color codes from log file output#164
Closed
jjjkkll157 wants to merge 1 commit into
Closed
Conversation
When logging.exception() writes to a FileHandler or non-TTY StreamHandler, the ANSI escape codes for syntax highlighting are now stripped automatically. Terminal output remains colored as before. - Add optional 'colored' parameter to format_exception() - Detect non-TTY streams in log.py and pass colored=False - Preserve existing colored stderr behavior Fixes #87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87 - strip ANSI escape codes from log file output when using FileHandler or non-TTY StreamHandler.