Skip to content

tstrsplit: add rev argument for reverse indexing (#6341)#7838

Merged
ben-schwen merged 6 commits into
masterfrom
issue6341
Jul 26, 2026
Merged

tstrsplit: add rev argument for reverse indexing (#6341)#7838
ben-schwen merged 6 commits into
masterfrom
issue6341

Conversation

@venom1204

@venom1204 venom1204 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

close #6341

this PR implements the rev argument in tstrsplit() to allow anchoring component extraction from the end of a string. This is particularly useful when strings have a varying number of delimiters and the user needs to extract the "last" or "second-to-last" elements.

hi @tdhock @joshhwuu can you have a look at this when you get time , thanks

@venom1204 venom1204 changed the title added parameter tstrsplit: add rev argument for reverse indexing (#6341) Jul 25, 2026
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (895067d) to head (0a6b256).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7838   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          88       88           
  Lines       17266    17270    +4     
=======================================
+ Hits        17097    17101    +4     
  Misses        169      169           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown
  • HEAD=issue6341 slower P<0.001 for memrecycle regression fixed in #5463
    Comparison Plot

Generated via commit 0a6b256

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 2 seconds
Installing different package versions 1 minutes and 14 seconds
Running and plotting the test cases 7 minutes and 46 seconds

Comment thread man/tstrsplit.Rd Outdated
Comment thread man/tstrsplit.Rd Outdated
@ben-schwen
ben-schwen merged commit 1508915 into master Jul 26, 2026
14 checks passed
@ben-schwen
ben-schwen deleted the issue6341 branch July 26, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: tstrsplit(... keep) additional options

2 participants