Skip to content

Update target dependency on sbncode PDMapAlg. - #938

Open
hgreenlee wants to merge 2 commits into
SBNSoftware:developfrom
hgreenlee:greenlee_fix_sbncode_cmake
Open

Update target dependency on sbncode PDMapAlg.#938
hgreenlee wants to merge 2 commits into
SBNSoftware:developfrom
hgreenlee:greenlee_fix_sbncode_cmake

Conversation

@hgreenlee

@hgreenlee hgreenlee commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is a companion to sbncode#651.

It changes the dependence of tool sbndPDMapAlg in directory OpDetSim to only depend on the relevant header, and not on the corresponding link library, which library wants to be private.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
SBNSoftware/sbncode#651

@hgreenlee hgreenlee added the bug Something isn't working label Jul 2, 2026
@hgreenlee
hgreenlee requested a review from PetrilloAtWork July 2, 2026 17:19
@hgreenlee hgreenlee self-assigned this Jul 2, 2026
@hgreenlee

Copy link
Copy Markdown
Contributor Author

Update checklist.

@PetrilloAtWork PetrilloAtWork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aantonakis

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_21_00 LArSoft/lar*@LARSOFT_SUITE_v10_21_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_21_02

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants