-
-
Notifications
You must be signed in to change notification settings - Fork 10
Upgrade date-fns@2 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SamVerschueren I'm not sure why the tests fail in Node 6. Can you please advise? |
This is weird, according to the docs https://github.com/SamVerschueren/listr-verbose-renderer/blob/master/test/fixtures/utils.js Looks like it should be something as this 'use strict';
const hookStd = require('hook-std');
const stripAnsi = require('strip-ansi');
exports.testOutput = (t, expected) => {
t.plan(t._test.planCount || expected.length);
let i = 0;
const promise = hookStd(actual => {
t.is(stripAnsi(actual), `${expected[i++]}`);
if (i === expected.length) {
promise.unhook();
}
});
}; |
@SamVerschueren what's the difference between what's currently in https://github.com/SamVerschueren/listr-verbose-renderer/blob/master/test/fixtures/utils.js and the snippet you posted in #8 (comment)? They look the same to me. Also, note that I didn't change the file in the first place. I'm not sure if |
The difference is the |
@SamVerschueren I missed that in the diff. Thanks. Is this something that you want to merge to |
Mega keen on this merge! |
@SamVerschueren any update on this? |
Sorry for the late replies and lack of response from my side. Released as |
Thanks for working on this! 🎉 |
date-fns@2
has been released, and sincelistr-verbose-renderer
is pinned on^1.x.x
, it makes it hard for userslistr-verbose-renderer
to usedate-fns@2
simultaneously, due to conflicting packages.This PR updates this dependency.
Note that this is a breaking change in
listr-verbose-renderer
for users who may have passed an invalid format (which previously worked) due to a breaking change in[email protected]
, to better conform the unicode standard