Fix flaky tests on src/validations/theme.test.ts
#77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were a bit flaky due to a race condition in the
beforeEach
setup. The code usedforEach
with async operations to create test directories, butforEach
doesn't wait for async functions to complete.That caused a race between directory creation and test execution, leading to
ENOENT
errors when tests tried to write files before directories existed.The fix involved replacing
forEach
withPromise.all()
to ensure all directory creation operations are completed before test execution begins. This change eliminates the timing-dependent behavior that caused the intermittent failures.Before:
After: