Skip to content

Support schema and doc errors in liquid tools #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Jul 29, 2025

Part of https://github.com/Shopify/developer-tools-team/issues/775
This is part 1 of two PRs where we are going to lean harder at using validate_theme as the primary validation tool for local theme development.
Part 2 will include changes to what errors the MCP will report to LLM (since we only want to mention the errors on files that the LLM created, not every file)

This PR fixes errors in validate_theme_codeblocks where it was not checking schema or liquid doc errors during theme-check due to missing dependencies.

@aswamy aswamy requested review from karreiro and EvilGenius13 July 29, 2025 19:36
@aswamy aswamy requested a review from a team as a code owner July 29, 2025 19:36
Copy link
Contributor

@EvilGenius13 EvilGenius13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're seeing the schema errors and other checks that we couldn't see before. I've been 🎩 against our test suite. Once the windows tests are passing this is good to go.

@aswamy aswamy force-pushed the support_schema_doc_errors branch 2 times, most recently from 4fa0fc0 to 3669fee Compare July 30, 2025 19:07
@aswamy aswamy force-pushed the support_schema_doc_errors branch from 3669fee to 5c46aa2 Compare July 30, 2025 19:14
@aswamy aswamy merged commit 3e50116 into main Jul 30, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants