Skip to content

Move tools into one file each #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

Move tools into one file each #87

merged 2 commits into from
Aug 5, 2025

Conversation

surma
Copy link
Member

@surma surma commented Aug 4, 2025

In preparation for automatic module loading, I moved each tool definition into its own file.

TODO:

  • Fix tests

@surma surma marked this pull request as ready for review August 5, 2025 11:01
@surma surma requested a review from a team as a code owner August 5, 2025 11:01
Copy link
Contributor

@matteodepalo matteodepalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a tiny comment, but the rest looks good.

@@ -0,0 +1,117 @@
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but could we change the name of this file to respect the camel case convention of the other files? Or was this difference made on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file was already named like this. It’s one of the few I didn’t create. I agree it should be aligned, but I’d have the same question!

@surma surma merged commit 40797ea into main Aug 5, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants