Skip to content

Backport #2701 to 2.1.x [copy] #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Copy of #2868, but without the yaml changes.

@antonfirsov antonfirsov mentioned this pull request Feb 24, 2025
4 tasks
@antonfirsov antonfirsov changed the title #2701 to 2.1.x [copy] Backport #2701 to 2.1.x [copy] Feb 24, 2025
@antonfirsov antonfirsov mentioned this pull request Feb 25, 2025
4 tasks
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@JimBobSquarePants JimBobSquarePants merged commit 4cb9f40 into release/2.1.x Feb 25, 2025
14 checks passed
@JimBobSquarePants JimBobSquarePants deleted the af/backport-2701 branch February 25, 2025 11:33
@Visual-Vincent
Copy link

Thank you for taking over this and getting it merged. Unfortunately I have been sick and therefore unable to make the necessary updates to my PR.

I see now that I had apparently not checked the checkbox that says "Allow edits by maintainers", which explains why you couldn't push to my branch. My apologies for that.

This was referenced Jul 23, 2025
This was referenced Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants