-
-
Notifications
You must be signed in to change notification settings - Fork 884
Backport #2701 to 2.1.x [copy] #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Thank you for taking over this and getting it merged. Unfortunately I have been sick and therefore unable to make the necessary updates to my PR. I see now that I had apparently not checked the checkbox that says "Allow edits by maintainers", which explains why you couldn't push to my branch. My apologies for that. |
Prerequisites
Description
Copy of #2868, but without the yaml changes.