Update playbook for chromium build #381
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This commit introduces a few changes to the playbook to make recreating the build process on different setups better. * Debug log at various steps in case credentials expire or ssh connections timeout * Creating an internet gateway in accounts which don't have that * Being able to run the build process in account with no default VPC * Filtering for the latest al2023 AMI if not present
ehossack
force-pushed
the
feat/update-ansible-playbook
branch
from
b88d207 to
39d76f6
Compare
|
Thanks, I don't think the majority of this is needed, the vpc stuff mostly. But there is some interesting things in this with the 'reconnect to host' stuff. There are many times when ansible has lost connection when gclient is syncing the chromium repo. |
|
@Sparticuz without this I couldn't get the compilation play to run in my account. Maybe you have different security settings, but I don't have a default VPC, nor can I create one, so this was all needed to get the complication going. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will obviously need tidying to make the process work with the new arm-supporting build, but these were the edits I needed to make to generate a 137 build.
I'm fairly confident in the changes here, but I'm a bit rusty on ansible, so I did rely on AI to help generate some of the code.