Skip to content

fix(i18n): standardize {filename} placeholder in addPageNumbers.customNumberDesc across all translations #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Aug 13, 2025

Description of Changes

  • Standardized the placeholder for filename in addPageNumbers.customNumberDesc to {filename} across all affected translation files.
  • Fixed inconsistent or localized variations (e.g., {filnavn}, {ime datoteke}, {nume_fisier}, {nome do arquivo}, {nama berkas}) and ensured the placeholder is uniform.
  • Corrected missing closing braces and quotes in several language files.
  • Affected locales include: ar_AR, az_AZ, bg_BG, da_DK, el_GR, en_GB, en_US, es_ES, ga_IE, hr_HR, id_ID, it_IT, nl_NL, no_NB, pl_PL, pt_BR, pt_PT, ro_RO, sk_SK, sl_SI, sr_LATN_RS, sv_SE, tr_TR, vi_VN.

@Frooodle please merge after #4202


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@Copilot Copilot AI review requested due to automatic review settings August 13, 2025 17:31
@dosubot dosubot bot added the size:M This PR changes 30-99 lines ignoring generated files. label Aug 13, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the {filename} placeholder in the addPageNumbers.customNumberDesc translation key across all language files. The changes ensure consistent placeholder naming and fix syntax errors in translation strings.

  • Replaced localized filename placeholder variations with the standard {filename} placeholder
  • Fixed missing closing quotes and braces in several translation files
  • Corrected typos and formatting issues in the translation strings

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
messages_vi_VN.properties Added missing closing quote
messages_tr_TR.properties Added missing closing quote
messages_sv_SE.properties Changed {filnamn} to {filename} and added missing quote
messages_sr_LATN_RS.properties Changed {ime_fajla} to {filename} and {ukupno} to {total}
messages_sl_SI.properties Added missing closing quote
messages_sk_SK.properties Added missing closing quote
messages_ro_RO.properties Changed {nume_fisier} to {filename} and added missing quote
messages_pt_PT.properties Added missing closing quote
messages_pt_BR.properties Changed {nome do arquivo} to {filename}
messages_pl_PL.properties Fixed formatting, typo Teskt to Tekst, and added missing quotes
messages_no_NB.properties Changed {filnavn} to {filename} and added missing quote
messages_nl_NL.properties Added missing closing quote
messages_it_IT.properties Added missing closing quote
messages_id_ID.properties Changed {nama berkas} to {filename}
messages_hr_HR.properties Changed {ime datoteke} to {filename}
messages_ga_IE.properties Added missing closing quote
messages_es_ES.properties Added missing closing quote
messages_en_US.properties Added missing closing quote
messages_en_GB.properties Added missing closing quote
messages_el_GR.properties Added missing closing quote
messages_da_DK.properties Changed {filnavn} to {filename} and added missing quote
messages_bg_BG.properties Added missing closing quote
messages_az_AZ.properties Added missing closing quote
messages_ar_AR.properties Added missing closing quote

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stirlingbot
Copy link
Contributor

stirlingbot bot commented Aug 13, 2025

🚀 Translation Verification Summary

🔄 Reference Branch: pr-branch-messages_en_GB.properties

📃 File Check: messages_ar_AR.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_az_AZ.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_bg_BG.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_da_DK.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_el_GR.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_en_GB.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_en_US.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_es_ES.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_ga_IE.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_hr_HR.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_id_ID.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_it_IT.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_nl_NL.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_no_NB.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_pl_PL.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_pt_BR.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_pt_PT.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_ro_RO.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_sk_SK.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_sl_SI.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_sr_LATN_RS.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_sv_SE.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_tr_TR.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

📃 File Check: messages_vi_VN.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

✅ Overall Check Status: Success

Thanks @Ludy87 for your help in keeping the translations up to date.

@stirlingbot stirlingbot bot added Translation Bugfix Pull requests that fix bugs labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Pull requests that fix bugs size:M This PR changes 30-99 lines ignoring generated files. Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant