-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
Refactor 🛠️Code improvements without changing behaviorCode improvements without changing behavior
Description
Description
Our current implementation of Park MVVM, and more specifically of the logic behind park naming, uses a specific _parkLocation
variable that allows us to call an API to obtain the correct park name. However, this park location is already stored in the ViewModel via the _currentPark
variable, so it would be simpler to use it directly for this task.
This refactor would allow us to lighten the ViewModel by removing duplicate variables and functions that have the same purpose.
Tasks
- Remove the
_parkLocation
variable from the Park ViewModel. - Adapt or remove the related Park ViewModel functions.
- Adapt all the projects files that use the
_parkLocation
variable - Adapt all the projects tests files that use the
_parkLocation
variable
Metadata
Metadata
Assignees
Labels
Refactor 🛠️Code improvements without changing behaviorCode improvements without changing behavior