Skip to content

ci: check toml in ci run#319

Merged
AzulGarza merged 2 commits into
mainfrom
ci/check-toml
Mar 17, 2026
Merged

ci: check toml in ci run#319
AzulGarza merged 2 commits into
mainfrom
ci/check-toml

Conversation

@spolisar

@spolisar spolisar commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Check toml-sort instead of sorting the file, so unsorted files are displayed in ci run.

Example output of a toml sort check failure:

ruff.....................................................................Passed
ruff-format..............................................................Passed
mypy.....................................................................Passed
toml-sort................................................................Failed
- hook id: toml-sort
- exit code: 1

1 check failure(s):
  - pyproject.toml

@spolisar spolisar requested a review from AzulGarza March 12, 2026 20:22
@spolisar

Copy link
Copy Markdown
Contributor Author

Two other options are:

  • setting up the action so that changes made by ruff, toml-sort, etc. get committed
  • setting up the action so that changes made by ruff, toml-sort, etc. get turned into a suggestion

@AzulGarza AzulGarza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @spolisar!

@AzulGarza AzulGarza merged commit cf4679e into main Mar 17, 2026
17 of 18 checks passed
@AzulGarza AzulGarza deleted the ci/check-toml branch March 17, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants