[Bug] [Lootlogger] Duplicate items on comparison #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes
Resolves #576
Changed functionality
Matching vaulted loot to looted items will now be iterative as intended, as opposed to the singleton compare on the first element of the looted list.
See #576 for more info.
Code Changes
LoggingBindings.UpdateItemsStatus()
to address the bug fix.LoggingBindingTests.cs
to ensure regression does not happen for the same issue.Testing
New introduced tests is passing as intended
