Skip to content

[Bug] [Lootlogger] Duplicate items on comparison #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2025

Conversation

DawtDawt
Copy link
Contributor

@DawtDawt DawtDawt commented Aug 9, 2025

Checklist

  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • All new and existing tests pass.

Changes

Resolves #576

Changed functionality

Matching vaulted loot to looted items will now be iterative as intended, as opposed to the singleton compare on the first element of the looted list.
See #576 for more info.

Code Changes

  • Modified business logic in LoggingBindings.UpdateItemsStatus() to address the bug fix.
  • Introduced testcase in LoggingBindingTests.cs to ensure regression does not happen for the same issue.

Testing

New introduced tests is passing as intended
image

@DawtDawt
Copy link
Contributor Author

DawtDawt commented Aug 9, 2025

Requesting @Triky313 for review.

@Triky313 Triky313 merged commit 1c7b346 into Triky313:dev Aug 10, 2025
2 checks passed
@DawtDawt DawtDawt deleted the 576-bug-duplicate-loot-log branch August 10, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants