Add option to warm lucene core query only #838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waziqi89
reviewed
Mar 20, 2025
| // have obtained this searcher from the NRTManager | ||
| // (i.e. sometimes we pulled from | ||
| // SearcherLifetimeManager, other times (if | ||
| // snapshot was specified) we opened ourselves, |
There was a problem hiding this comment.
We may not want to warm the query with specific generation, i.e. snapshot. But this is likely a fix in saving criteria.
waziqi89
approved these changes
Mar 20, 2025
src/main/java/com/yelp/nrtsearch/server/luceneserver/search/SearchRequestProcessor.java
Show resolved
Hide resolved
waziqi89
reviewed
Mar 20, 2025
| @@ -257,7 +257,8 @@ public void initWarmer(Archiver archiver, String indexName) { | |||
| archiver, | |||
| configuration.getServiceName(), | |||
| indexName, | |||
| warmerConfig.getMaxWarmingQueries()); | |||
| warmerConfig.getMaxWarmingQueries(), | |||
| warmerConfig.getMaxWarmingLuceneQueryOnlyCount()); | |||
There was a problem hiding this comment.
You can still use the % settings in your final PR if you prefer
RavirajDataEngineering
force-pushed
the
profiling
branch
from
68b7264 to
7b49072
Compare
|
Not needed anymore due to #844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.