dhruva_RP-13223-Parent_field_access_from_nested_query #868

dhruva-r · 2025-07-14T15:18:40Z

Jira Ticket

RP-13223

Summary of Changes

Added support for nested queries to be able to access parent document fields. The docLookup object will now use a new NESTED_DOCUMENT_OFFSET meta field to calculate the docId of the the parent document and will be able to retrieve fields from the parent document if they do not exist in the child document.

Tests

Unit tests and an end to end test created provide sufficient code coverage.

…t_field_access_from_nested_query

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

… field using "_PARENT." notation

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

…ARENT." notation.

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

src/main/java/com/yelp/nrtsearch/server/field/ObjectFieldDef.java

src/main/java/com/yelp/nrtsearch/server/index/IndexState.java

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

…ENT. prefix but now recursively calls the get function of SegmentDocLookup to handle multiple levels of nested objects

…ue of the offset field

…ocumentHandler

…stProcessor in response to use nestedPath to determine if the field is on the parent level or the child level.

dhruva-r · 2025-07-17T20:29:22Z

I need to add a test for multiple nested documents (and checking the offset values), a test for multi levelled nested documents

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

src/main/java/com/yelp/nrtsearch/server/search/SearchRequestProcessor.java

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

src/main/java/com/yelp/nrtsearch/server/search/SearchRequestProcessor.java

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

…t, getParentDocId returns exceptions instead of -1

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java

…ldDef directly

dhruva-r added 2 commits July 14, 2025 10:58

Enabling parent fields to be retrieved from nested queries.

081df5a

Merge remote-tracking branch 'origin/main' into dhruva_RP-13223-Paren…

ff2d83e

…t_field_access_from_nested_query

dhruva-r requested review from sarthakn7 and waziqi89 July 14, 2025 15:18

dhruva-r self-assigned this Jul 14, 2025

dhruva-r marked this pull request as ready for review July 14, 2025 17:35

dhruva-r added 2 commits July 14, 2025 13:52

Removing redundant comments.

d11e66a

gradlew spotlessApply

4a9e954

waziqi89 reviewed Jul 15, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

dhruva-r added 2 commits July 16, 2025 10:35

Addressing PR comments, adding parameter to the tryGetFromParentDocument

7b91b89

Addressing PR comments; Added support to explicitly retrieve a parent…

b4d4afa

… field using "_PARENT." notation

dhruva-r requested a review from waziqi89 July 16, 2025 16:44

waziqi89 reviewed Jul 16, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

waziqi89 reviewed Jul 16, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

Removed fallback mechanism, updated test cases to only handle the "_P…

412c5e7

…ARENT." notation.

dhruva-r requested a review from waziqi89 July 16, 2025 20:10

waziqi89 reviewed Jul 16, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

aprudhomme reviewed Jul 16, 2025

View reviewed changes

sarthakn7 reviewed Jul 16, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

dhruva-r added 4 commits July 17, 2025 11:00

Updated IndexState to be more precise, implementation still uses _PAR…

3de07f7

…ENT. prefix but now recursively calls the get function of SegmentDocLookup to handle multiple levels of nested objects

Removed a test file, commented another method of initializing the val…

a2d7cf4

…ue of the offset field

Removed offset calculation in ObjectFieldDef and moved it to the AddD…

5e04c6a

…ocumentHandler

Removedthe _PARENT. prefix. Enhanced segmentDocLookup and SearchReque…

e8c1889

…stProcessor in response to use nestedPath to determine if the field is on the parent level or the child level.

dhruva-r requested review from aprudhomme, sarthakn7 and waziqi89 July 17, 2025 20:29

dhruva-r commented Jul 17, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

aprudhomme reviewed Jul 18, 2025

View reviewed changes

sarthakn7 reviewed Jul 18, 2025

View reviewed changes

Reverting SegmentDocLookup to only handle 1 layer of nesting

8b39e35

dhruva-r requested a review from sarthakn7 July 22, 2025 16:16

Reverting design to use _PARENT notation

f9648ff

waziqi89 reviewed Jul 23, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

waziqi89 reviewed Jul 23, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Show resolved Hide resolved

waziqi89 reviewed Jul 23, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Show resolved Hide resolved

Fixed bug where new parentLookup object was created for every documen…

619a488

…t, getParentDocId returns exceptions instead of -1

dhruva-r requested review from waziqi89 and aprudhomme July 23, 2025 16:30

waziqi89 previously approved these changes Jul 23, 2025

View reviewed changes

sarthakn7 reviewed Jul 23, 2025

View reviewed changes

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

src/main/java/com/yelp/nrtsearch/server/doc/SegmentDocLookup.java Outdated Show resolved Hide resolved

Removed redundant try catch block, and type cast the return of getFie…

d7bddc6

…ldDef directly

dhruva-r dismissed waziqi89’s stale review via d7bddc6 July 23, 2025 19:55

waziqi89 approved these changes Jul 23, 2025

View reviewed changes

sarthakn7 approved these changes Jul 23, 2025

View reviewed changes

dhruva-r merged commit 6c1efe4 into main Jul 23, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dhruva_RP-13223-Parent_field_access_from_nested_query #868

dhruva_RP-13223-Parent_field_access_from_nested_query #868

Uh oh!

dhruva-r commented Jul 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhruva-r commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhruva_RP-13223-Parent_field_access_from_nested_query #868

dhruva_RP-13223-Parent_field_access_from_nested_query #868

Uh oh!

Conversation

dhruva-r commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira Ticket

Summary of Changes

Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhruva-r commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhruva-r commented Jul 14, 2025 •

edited

Loading