Skip to content

feat(files): improve file preview error handling and use FileResponse#5115

Merged
rayrayraykk merged 2 commits into
agentscope-ai:mainfrom
zhijianma:feat/improve-file-prview-error
Jun 11, 2026
Merged

feat(files): improve file preview error handling and use FileResponse#5115
rayrayraykk merged 2 commits into
agentscope-ai:mainfrom
zhijianma:feat/improve-file-prview-error

Conversation

@zhijianma

Copy link
Copy Markdown
Member

Description

[Describe what this PR does and why]

Related Issue: Fixes #(issue_number) or Relates to #(issue_number)

Security Considerations: [If applicable, e.g. channel auth, env/config handling]

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Core / Backend (app, agents, config, providers, utils, local_models)
  • Console (frontend web UI)
  • Channels (DingTalk, Feishu, QQ, Discord, iMessage, etc.)
  • Skills
  • CLI
  • Documentation (website)
  • Tests
  • CI/CD
  • Scripts / Deploy

Checklist

  • I ran pre-commit run --all-files locally and it passes
  • If pre-commit auto-fixed files, I committed those changes and reran checks
  • I ran tests locally (pytest or as relevant) and they pass
  • Documentation updated (if needed)
  • Ready for review

For Channel Changes (DingTalk, Feishu, QQ, Console, etc.)

  • I ran ./scripts/check-channels.sh (or ./scripts/check-channels.sh --changed) and it passes
  • Contract test exists in tests/contract/channels/test_<channel>_contract.py (REQUIRED)
  • Contract test implements create_instance() with proper channel initialization
  • All 19 contract verification points pass (see tests/contract/channels/__init__.py)
  • Optional: Unit tests in tests/unit/channels/test_<channel>.py for complex internal logic

Testing

[How to test these changes]

Local Verification Evidence

pre-commit run --all-files
# paste summary result

pytest
# paste summary result

Additional Notes

[Optional: any other context]

@github-actions

Copy link
Copy Markdown

Welcome to QwenPaw! 🐾

Hi @zhijianma, this is your 142nd Pull Request.

🙌 Join Developer Community

Thanks so much for your contribution! We'd love to invite you to join the official QwenPaw developer group! You can find the Discord and DingTalk group links under the "Developer Community" section on our docs page:
https://qwenpaw.agentscope.io/docs/community

We truly appreciate your enthusiasm—and look forward to your future contributions! 😊

We'll review your PR soon.

@zhijianma zhijianma force-pushed the feat/improve-file-prview-error branch from b13231c to eca89e3 Compare June 11, 2026 07:22
@zhijianma zhijianma requested a deployment to maintainer-approved June 11, 2026 07:22 — with GitHub Actions Waiting
@zhijianma zhijianma linked an issue Jun 11, 2026 that may be closed by this pull request
@rayrayraykk rayrayraykk merged commit 1f3715b into agentscope-ai:main Jun 11, 2026
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in QwenPaw Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Question]: 1.1.11版本对话中的附件问题

2 participants