Project seetings are not accessable

[AlUser71]

By using the redmine_bunner plugin in version 0.2.2 or 0.3.0 the project settings can't be accessed anymore.

It seems that it is caused by issue #120 by changing lib/banners/projects_helper_patch.rb.

If we patch projects_helper_patch.rb and replace again
ProjectsHelper.prepend(Banners::ProjectsHelperPatch)
by
ProjectsController.helper(Banners::ProjectsHelperPatch)
it works again.

Our patched version looks like this now:

unless ProjectsHelper.included_modules.include?(Banners::ProjectsHelperPatch)
  ProjectsController.helper(Banners::ProjectsHelperPatch)
end

I don't know if there are side effects that I could not figure out so far.

[akiko-pusu]

Hi, @AlUser71
Thanks for your reporting.

I don't know if there are side effects that I could not figure out so far.

It depends on your environment.
Could you please more detailed information about your environment?
Such as Redmine version, installed plugins and so on.

Some plugins often conflict with each other.

[AlUser71]

Hi, @akiko-pusu
please find attched our Redmine configuration.

For us it is important to know, if the change/patch that we applied to your code (projects_helper) is OK from your point of view (#127 (comment)).

[akiko-pusu]

Thanks for your additional information.
Let me confirm, is your Redmine instance clean installed one or not?

It's hard for me to find the plugin that conflicts with Redmine Banner.
easy_xxxx series

And I'm going to refactor not to use project setting tab like this:

• Pull request to prevent the project setting tab's conflict. redmine_issue_templates#299

BTW, thanks for using Issue Template plugin v1.0.0.

[AlUser71]

I understand that you can't check or validate your plugin against any other plugin, that's OK.

But what we would like to know is:
Is the change that we have applied OK from your point of view regarding the banner plugin or not? Currently we don't have any problem by using our changed version.

• Code in projects_helper_patch.rb in version 0.3.0, not working in our environment (project setting pages not accesable):

unless ProjectsHelper.included_modules.include?(Banners::ProjectsHelperPatch)
  ProjectsHelper.prepend(Banners::ProjectsHelperPatch) )
end

• Our modified version, works in our environment:

unless ProjectsHelper.included_modules.include?(Banners::ProjectsHelperPatch)
  ProjectsController.helper(Banners::ProjectsHelperPatch)
end

[AlUser71]

Sorry, closing the issue was a mistake.

[akiko-pusu]

Hi, I've modified not to use the project setting tab but to use the project menu to access the banner edit screen. (Please see: #128)

Now, this update is included in the dev branch and soon it will be merged into the master.