[core] New dynamic output attributes #2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcastan
force-pushed
the
dev/dynamicOutputValue
branch
from
19d93f6 to
d5e356c
Compare
…s not exist as they are not saved in the project So we always check if they exist before accessing them.
The update is done at the same place as the status update. This is a duplicate that is not needed.
…e of dynamic output attributes For dynamic output attributes, the UID does not depend on the attribute value. In particular, when loading a project file, the UIDs are updated first, and the node status and the dynamic output values are not yet loaded, so we should not read the attribute value.
During the serialization to JSON, dict keys are converted to string. We need to convert them back to int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an output attribute's default value is set to None, it is treated as dynamic. This means that its value will be determined at runtime by the node. As a result, this output value is not saved within the project to prevent invalidating the scene during graph computation. Instead, the output values of these dynamic attributes are stored in the node's cache folder.