Feature/transformation #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add clearer error messages when domain primitive types are not declared as class or struct based on the underlying type. - Remove unused commented code in Executor.cs. - Add new diagnostic helpers for better clarity and maintainability.
- Introduced Transform method support in domain primitives. - Added unit tests for Transform behavior. - Updated README with usage instructions. - Bumped version to 6.0.0 and updated dependencies. - Minor generator and Swagger improvements.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for an optional Transform method on domain primitives, enabling preprocessing of input values before validation and instantiation. It adds generator logic to detect and invoke Transform, updates tests, diagnostics, and documentation accordingly.
- Add
UseTransformMethodflag and detection inExecutor - Modify code generation to call
Transformin constructors andTryCreate - Update tests, docs, diagnostics, and version bumps
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/.../DomainPrimitiveGeneratorTest.cs | New test for verifying transformer call count when Transform is defined |
| tests/.../AltaSoft.DomainPrimitives.Generator.Tests.csproj | Bump test dependencies to latest versions |
| src/.../Generator/Models/GeneratorData.cs | Added UseTransformMethod property |
| src/.../Generator/Helpers/MethodGeneratorHelper.cs | Inject Transform call before validation in generated methods |
| src/.../Generator/Executor.cs | Detect Transform method, set flag, enforce class/struct constraints |
| src/.../Generator/Helpers/DiagnosticHelper.cs | New diagnostics for invalid type kinds, remove commented code |
| src/.../AltaSoft.DomainPrimitives.Generator.csproj | Bump generator dependencies |
| src/.../XmlDataTypes/AsciiString.cs | Minor formatting |
| src/.../XmlDataTypes/AltaSoft.DomainPrimitives.XmlDataTypes.csproj | Bump SwaggerGen version |
| README.md | Add Transform Method documentation section |
| Directory.Build.props | Version bumped to 6.0.0 |
| AltaSoft.DomainPrimitives.sln | Add AltaSoft.DomainPrimitives.UnitTests project |
src/AltaSoft.DomainPrimitives.Generator/Helpers/DiagnosticHelper.cs
Outdated
Show resolved
Hide resolved
| @@ -14,6 +14,7 @@ | |||
| - [Installation](#installation) | |||
| - [Creating your Domain type](#creating-your-domain-type) | |||
| - [Json Conversion](#json-conversion) | |||
| - [Transform Method](#transform-method) | |||
There was a problem hiding this comment.
[nitpick] The link target #transform-method may not match the generated heading ID that includes an emoji (#🔄-transform-method). Update either the link or heading text to ensure correct navigation.
Copilot uses AI. Check for mistakes.
src/AltaSoft.DomainPrimitives.Generator/Models/GeneratorData.cs
Outdated
Show resolved
Hide resolved
…er.cs Duplicated Id of diagnostics Co-authored-by: Copilot <[email protected]>
GregoryNikolaishvili
approved these changes
May 19, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.