RFC: Lint Django model `.save()` calls without `update_fields` argument

[eht16]

This is not (yet) a feature request, just a request for comments.

What about a new rule to check for .save() calls of Django models with no explicit update_fields keyword argument specified?

I think in general, it is a good idea to explicitly use update_fields when saving Django models.

Though there are probably also cases where it is not possible at all (e.g. you simply do not know which fields were updated when using one or more subclasses or mixins or so). Or maybe there are cases where you explicitly want to save all fields of the model.

So, do you think such a rule might be too ambitious or might it work in general and it's feasible to declare corner cases with the noqa tag?

[GitRon]

Hi @eht16!

Thanks for the ticket. I totally get your motivation and given the opinionated nature of some of our rules, we just might add this and if you don't like it, just ignore it. I've just added a disclaimer about this pattern.

If you find the time, feel free to create a PR.

Best
Ronny