Skip to content

feat(app): show loader on session hover#34224

Open
arvsrn wants to merge 1 commit into
anomalyco:devfrom
arvsrn:show-loader-on-session-hover
Open

feat(app): show loader on session hover#34224
arvsrn wants to merge 1 commit into
anomalyco:devfrom
arvsrn:show-loader-on-session-hover

Conversation

@arvsrn

@arvsrn arvsrn commented Jun 27, 2026

Copy link
Copy Markdown
Member

Issue for this PR

N/A

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Aligns home page behaviour with tabs: when a session is in-progress, hovering on the row replaces the loader with the project avatar. This only happens if no project is selected.

How did you verify your code works?

  • Ran the app locally and verified the updated UI manually
  • Ran type checks locally (bun turbo typecheck)

Screenshots / recordings

Screen.Recording.2026-06-27.at.18.13.17.mov

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@arvsrn arvsrn requested review from Brendonovich and Hona as code owners June 27, 2026 12:44
@andrei-hasna

Copy link
Copy Markdown

Merge review result: local merge simulation against current origin/dev (ae53163) succeeded with only the two expected files changed. Focused validation passed: git diff --check, bun install --frozen-lockfile, bun typecheck from packages/app, and oxlint on the changed files. A separate adversarial verifier also passed the change and ran packages/app build successfully.

Not merged by this automation run because the active GitHub account does not have push/merge access to the repository; GitHub returned 403 when checking collaborator permission (must have push access).

@andrei-hasna

Copy link
Copy Markdown

Automated merge review completed. The PR is open, non-draft, mergeable/clean at head 07c4a3c45acf50f00cd506dd804eaf1c9f4dff77, and all GitHub checks are passing. I also validated an isolated merge onto current dev (61a7f6db35e1b8284258de247b889edf14748234) with app typecheck, app production build, touched-file lint, whitespace check, and diff secret scan.\n\nNo code blockers were found. The merge itself could not be performed by this worker because the authenticated GitHub account does not have MergePullRequest permission on this repository.

@andrei-hasna

Copy link
Copy Markdown

Validation update from merge queue task cbd196ae:

  • PR is open, non-draft, mergeable/clean per GitHub metadata.
  • All listed GitHub checks are passing.
  • Local merge of the PR head into current remote dev succeeded cleanly.
  • Local validation passed: bun install --frozen-lockfile, bun --cwd packages/app typecheck, bun --cwd packages/app test:unit (488 pass), bun --cwd packages/app test:browser (17 pass), and bun oxlint packages/app/src/pages/home.tsx packages/app/src/pages/layout/session-tab-avatar.tsx exited 0 with unrelated pre-existing warnings.
  • Local validation failed: bun prettier --check packages/app/src/pages/home.tsx packages/app/src/pages/layout/session-tab-avatar.tsx reports packages/app/src/pages/layout/session-tab-avatar.tsx needs formatting.

I attempted a formatting-only fix, but pushing to the contributor branch was rejected with 403 for my active GitHub account. Blocking merge until that Prettier formatting change is applied and checks are revalidated.

@andrei-hasna

Copy link
Copy Markdown

Fresh merge-queue validation for task e05468c9 (2026-06-28):

  • PR is still open, non-draft, MERGEABLE/CLEAN at head 07c4a3c45acf50f00cd506dd804eaf1c9f4dff77.
  • Live dev is dfeb1b5051a05b359bd4af711b204d2c0342c5f4; a synthetic merge onto that ref was conflict-free.
  • Passed locally on the synthetic merge: packages/app typecheck, packages/app production build, focused oxlint on the two touched files, git diff --check, and diff secret-pattern scan.
  • Independent adversarial code review found no behavior blocker.

Not merged by this worker because formatting validation still fails: bunx --bun prettier --check packages/app/src/pages/home.tsx packages/app/src/pages/layout/session-tab-avatar.tsx reports packages/app/src/pages/layout/session-tab-avatar.tsx needs formatting. The active GitHub account also has READ permission only (viewerCanUpdate=false), so this worker cannot push the formatting-only fix or merge the PR.

Required unblock: apply Prettier formatting to packages/app/src/pages/layout/session-tab-avatar.tsx, rerun focused validation/checks, then re-evaluate merge with a merge-capable account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants