fix: merge MCP config files with built-in servers#1546
Open
hogeheer499-commits wants to merge 1 commit into
Open
fix: merge MCP config files with built-in servers#1546hogeheer499-commits wants to merge 1 commit into
hogeheer499-commits wants to merge 1 commit into
Conversation
hogeheer499-commits
marked this pull request as ready for review
July 24, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1544.
When the action prepends its built-in MCP config, a later
--mcp-config <file>is currently remembered but never included in the merged value. The user's servers therefore disappear without an error while the built-in servers still work.This reads file-path configs when multiple MCP configs need to be combined and merges their
mcpServersin argument order, preserving the existing later-value precedence. A regression test exercises the built-in inline config plus user file-path case.Tests:
bun test(804 passed)bun run typecheckbun run format:check