reject tokenVocab names containing a path separator#4957
Open
abdul7056 wants to merge 1 commit into
Open
Conversation
The option value is resolved against the lib, output and grammar directories, so a name with a path separator reads a .tokens file outside all three and unparsable lines are echoed into tool output. Signed-off-by: abdul7056 <abdul@sproutxp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tokenVocaboption value is used verbatim to build the.tokenspath inTokenVocabParser:getImportedVocabFileresolves it againstlibDirectory,outputDirectoryand the grammar directory, none of which constrain the resultoptions { tokenVocab='../../secret/creds'; }resolves outside all three rootsTOKENS_FILE_SYNTAX_ERROR, putting the contents of the opened file into tool outputRejecting names that carry a path separator before anything is opened.
antlr4-maven-pluginalready reduces this same value withstripPath, so a bare grammar name is the expected shape.