perf(parquet): Optimize DeltaByteArrayEncoder and friends#10412
Open
MassivePizza wants to merge 11 commits into
Open
perf(parquet): Optimize DeltaByteArrayEncoder and friends#10412MassivePizza wants to merge 11 commits into
MassivePizza wants to merge 11 commits into
Conversation
MassivePizza
marked this pull request as ready for review
July 23, 2026 12:18
Contributor
|
run benchmark arrow_writer |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
Author
|
That bench sure looks noisy. I'm not sure which benches actually use DeltaByteArray encoding, but parquet_2 should generally enable it for byte arrays (i.e. decimals and strings) AFAIK. I'll test again locally to make sure nothing is too broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
In our case, improve performance for delta-encoded decimals.
What changes are included in this PR?
Reduce allocs and copies when delta-encoding byte-arrays.
Also removed some suspicious
#[cold]attributes onEncoder::encoding.Are these changes tested?
Encoder correctness should be covered by existing tests.
I can add benchmarks if desired, since the removal of byte array copies is a nice win (especially combined with #10364).
Are there any user-facing changes?
parquet::encodings::encoding::Encoderhas a newflush_tofunction, but the module is gated behind the experimental feature. I can rewrite it to makeflush_toa default method if needed.