fix(arrow-schema): stop asserting on unstable TryFromIntError message in tests#10433
Merged
Merged
Conversation
bit2swaz
force-pushed
the
fix/miri-tryfromint-message
branch
from
July 25, 2026 03:30
96f5a42 to
b373c23
Compare
alamb
approved these changes
Jul 25, 2026
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No separate issue. The fix is one line per test case and the failing CI runs are evidence enough.
Rationale for this change
MIRI CI uses nightly Rust. A recent nightly changed the
Displayoutput ofTryFromIntErrorfrom"out of range integral type conversion attempted"to"number too large to fit in target type"(and similar variants). Tests indatatype_parse.rswere asserting on that stdlib-owned suffix, so they broke on MIRI without any change to our code.What changes are included in this PR?
Trimmed 9 expected substrings in
parse_data_type_errorsto stop at the:that separates our message from the stdlib one. The tests now only assert on the part of the error string we control.Are these changes tested?
parse_data_type_errorspasses on stable. MIRI CI should go green once this merges.Are there any user-facing changes?
No. Test-only change, no behavior or API impact.