GH-50596: [C++] AppendScalar implementation uses polymorphism#50652
Open
KHARSHAVARDHAN-eng wants to merge 2 commits into
Open
GH-50596: [C++] AppendScalar implementation uses polymorphism#50652KHARSHAVARDHAN-eng wants to merge 2 commits into
KHARSHAVARDHAN-eng wants to merge 2 commits into
Conversation
Replace the centralized AppendScalarImpl visitor with virtual AppendScalar and AppendScalars overrides on builder classes. This moves scalar append logic into the appropriate builder hierarchy, removing the need for runtime dispatch through AppendScalarImpl while preserving existing behavior.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayBuilder::AppendScalarandAppendScalarspreviously relied on thecentralized
AppendScalarImplvisitor to dispatch scalar appends based onthe scalar type.
This refactors scalar appending to use virtual method polymorphism within
the builder hierarchy, moving the implementation into the appropriate
builder classes while preserving the existing behavior.
Implementation
AppendScalarImplvisitor.AppendScalarandAppendScalarson the relevant builderclasses.
dispatch with virtual method polymorphism.
Testing
arrow-array-test.arrow-array-testsuite.