[ISSUE #4403] Fix the SPI extension admin-api loading of storage-plugins #4404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4404 +/- ##
============================================
- Coverage 17.82% 17.75% -0.08%
Complexity 1514 1514
============================================
Files 604 612 +8
Lines 25559 25664 +105
Branches 2400 2400
============================================
Hits 4556 4556
- Misses 20564 20669 +105
Partials 439 439
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
approved these changes
Aug 28, 2023
lrhkobe
approved these changes
Aug 28, 2023
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…e-plugins (apache#4404) * fix: remove knative circulate dependency * feat: realize knative admin-api * feat: realize mongodb admin-api * feat: realize pulsar admin-api * feat: realize pravega admin-api * fix: deliver a config to client instead of null * chore: revert startup plugin config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4403.
Motivation
storage-plugins didn't realize
org.apache.eventmesh.api.admin.Adminand cause boot failure.Modifications
It is a quick fix, including:
not including:
Verification
PravegaStorageResourceServiceImpl is special comparing with other storage-plugins, because it connects pravega server on EventMesh startup. I deployed a pravega and the connection established.
Documentation