[FLINK-37937] Test Cassandra source in real cluster conditions to better test the split #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to update size estimates: flush updates the SSTables and refreshsizeestimates updates the size estimates based on them
…ions that are not interpretend by Cassandra
…tion accessible to tests and not call estimate_size during tests. In refreshSizeEstimates wait until system.size_estimates has at least a row that has non-null mean_partition_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in split calculation (ring fraction calculation) was uncovered by this PR. The existing split tests are run on an embedded Cassandra cluster with only one node. This leads to having ringFraction always equal to 1 (the single node hosts 100% of the data) during the tests. This masks the bug.
Test splits on an embedded cluster of 2 nodes.
Additional changes:
PS: tests are longer to setup because of the node cluster: measured on my laptop 2min16 vs 57s but the better split testings is worth it I think.
R: @Poorvankbhatia