Skip to content

Adds configurable hosts for hamilton ui #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skrawcz merged 1 commit into from
Jul 1, 2024
Merged

Adds configurable hosts for hamilton ui #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ui/backend/server/server/settings_mini.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import logging
import os
import socket
from pathlib import Path

logger = logging.getLogger(__name__)


def get_from_env(
var_name: str, valid_values: list = None, allow_missing: bool = False, default_value: str = None
Expand Down Expand Up @@ -34,7 +38,19 @@ def get_from_env(

HAMILTON_AUTH_MODE = "permissive"

ALLOWED_HOSTS = ["localhost", "backend", "0.0.0.0", "127.0.0.1"]
# set up allowed hosts
try:
hostname = socket.gethostname()
local_ip = socket.gethostbyname(hostname)
hosts_to_add = [local_ip, hostname]
except Exception:
logger.warning("Could not get hostname or local IP")
hosts_to_add = []
ALLOWED_HOSTS = ["localhost", "backend", "0.0.0.0", "127.0.0.1", "colab.research.google.com"]
ALLOWED_HOSTS = (
ALLOWED_HOSTS + hosts_to_add + os.environ.get("HAMILTON_ALLOWED_HOSTS", "").split(",")
)
logger.debug(f"ALLOWED_HOSTS: {ALLOWED_HOSTS}")

HAMILTON_BLOB_STORE = "local"

Expand Down